Allow upstream to be undici.BalancedPool, pass maxRetriesOn503 to replyOpts#428
Open
Antiavanti wants to merge 1 commit intofastify:mainfrom
Open
Allow upstream to be undici.BalancedPool, pass maxRetriesOn503 to replyOpts#428Antiavanti wants to merge 1 commit intofastify:mainfrom
upstream to be undici.BalancedPool, pass maxRetriesOn503 to replyOpts#428Antiavanti wants to merge 1 commit intofastify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
upstreamtype to be compatible withbase, based on assumption fromfromOpts.base = opts.upstream->base: string[]introduced in fastify/fastify-reply-from#421 (#279 (comment)).Pass
maxRetriesOn503toreplyOpts, which is not part ofFastifyReplyFromOptions, but is expected to be on this level (#34 (comment)).Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct