Skip to content

Conversation

@tisonkun
Copy link
Contributor

This closes #8.

Since we're going to use traversable to integrate the visitor pattern, not sure if we should still keep derive-visitor feature flag: it does not harm, but may spread discouraged practice.

Signed-off-by: tison <wander4096@gmail.com>

let stacksafe_crate = crate_path.unwrap_or_else(|| parse_quote!(::stacksafe));

let block = &item_fn.block;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid rust-lang/rust-clippy#15968.

And somehow this avoids a new box allocation.

@tisonkun tisonkun requested a review from andylokandy November 3, 2025 15:41
@tisonkun
Copy link
Contributor Author

tisonkun commented Nov 3, 2025

Integration tests with ScopeDB passed. Will remove the feature flag to derive-visitor later and release a 1.0.

Signed-off-by: tison <wander4096@gmail.com>
@andylokandy andylokandy merged commit 6eb5efb into main Nov 4, 2025
11 checks passed
@andylokandy andylokandy deleted the release-1 branch November 4, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call a 1.0 release?

3 participants