Skip to content

Conversation

@tisonkun
Copy link
Contributor

This closes #11 .

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from andylokandy January 28, 2025 12:51
@tisonkun
Copy link
Contributor Author

@andylokandy May we release a 1.0.0 after this PR merged?

Signed-off-by: tison <wander4096@gmail.com>
@andylokandy andylokandy merged commit cb8f984 into main Jan 30, 2025
5 checks passed
@andylokandy andylokandy deleted the option branch January 30, 2025 06:48
@andylokandy
Copy link
Collaborator

Thank you!

@andylokandy
Copy link
Collaborator

andylokandy commented Jan 30, 2025

May we release a 1.0.0 after this PR merged?

Do you think there is any improvement has to be made before 1.0?

@tisonkun
Copy link
Contributor Author

Do you think there is any improvement has to be made before 1.0?

Not yet.

Logcall is designed to automatically log function calls, their inputs, and their outputs. Our current state should solve it well.

I'm considering adding more options to manipulating log!'s param, or support other Try trait impl (or directly over the Try trait). However, these can be over generic at this point, and adding more support won't break compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Would be nice to have some and none like ok and err

3 participants