Skip to content

refactor: rename Exn::from_iter to raise_all #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tisonkun merged 1 commit into from
Jan 17, 2026
Merged

refactor: rename Exn::from_iter to raise_all #33

tisonkun merged 1 commit into from
Jan 17, 2026

Conversation

@andylokandy
Copy link
Contributor

@andylokandy andylokandy commented Jan 17, 2026

No description provided.

@andylokandy andylokandy requested a review from tisonkun January 17, 2026 05:50
tisonkun
tisonkun approved these changes Jan 17, 2026
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any additional background for this rename?

@andylokandy
Copy link
Contributor Author

andylokandy commented Jan 17, 2026

Any additional background for this rename?

  1. Align the error argument order with Exn::new and Exn::raise, where the new error layer stays on the left.
  2. Make the raise sematic more obvious.

@tisonkun
Copy link
Contributor

tisonkun commented Jan 17, 2026

Sounds reasonable!

@tisonkun tisonkun merged commit 3179a17 into fast:main Jan 17, 2026
9 checks passed
This was referenced Jan 17, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andylokandy @tisonkun