-
Notifications
You must be signed in to change notification settings - Fork 5
feat: impl std::error::Error for Frame #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Seems not possible to override and proxy the |
anyhow does the same--disallowing downcast once boxed into a |
2d5a155 to
f407f57
Compare
87b1908 to
148952e
Compare
Based on our API, one can first downcast the Error to Frame and then call Frame::error to fetch the internal error and call downcast on that error instead? |
tisonkun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
We may considere how to introduce the concept of Frame to users.
Exn is the final interface and Frame wraps the inner error that users can do some advanced interaction; see examples?
Yes. |
This refers to #20