Skip to content

Cancel and confirm events are now broadcasted. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
punknroll wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Cancel and confirm events are now broadcasted. #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c00eeec
Cancel and confirm events are now broadcasted.
styleflasherdev Sep 17, 2015
a1ec966
dist files new also have the new broadcast events
styleflasherdev Oct 13, 2015
b3ea526
included pull request https://github.com/facultymatt/angular-unsavedC…
punknroll Jul 13, 2018
13453b2
confirmation messsage was only shown once
punknroll Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions dist/unsavedChanges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ angular.module('unsavedChanges', ['resettable'])
});
removeFunctions = [];
$window.onbeforeunload = null;
unsavedWarningsConfig.hasConfirmed = false;
}

// Function called when user tries to close the window
Expand All @@ -195,25 +196,30 @@ angular.module('unsavedChanges', ['resettable'])
$window.onbeforeunload = _this.confirmExit;

var eventsToWatchFor = unsavedWarningsConfig.routeEvent;

angular.forEach(eventsToWatchFor, function(aEvent) {
angular.forEach(eventsToWatchFor, function (aEvent) {
//calling this function later will unbind this, acting as $off()
var removeFn = $rootScope.$on(aEvent, function(event, next, current) {
var removeFn = $rootScope.$on(aEvent, function (event, next, current) {
unsavedWarningsConfig.log("user is moving with " + aEvent);
// @todo this could be written a lot cleaner!
if (!allFormsClean()) {
unsavedWarningsConfig.log("a form is dirty");
if (!confirm(unsavedWarningsConfig.navigateMessage)) {
unsavedWarningsConfig.log("user wants to cancel leaving");
event.preventDefault(); // user clicks cancel, wants to stay on page
if (unsavedWarningsConfig.hasConfirmed) {
unsavedWarningsConfig.log("user already confirmed, skipping confirmation for " + aEvent);
}
else {
// @todo this could be written a lot cleaner!
if (!allFormsClean()) {
unsavedWarningsConfig.log("a form is dirty");
if (!confirm(unsavedWarningsConfig.navigateMessage)) {
$rootScope.$broadcast('unsavedChanges:cancel');
unsavedWarningsConfig.log("user wants to cancel leaving");
event.preventDefault(); // user clicks cancel, wants to stay on page
} else {
unsavedWarningsConfig.hasConfirmed = true;
unsavedWarningsConfig.log("user doesn't care about loosing stuff...");
$rootScope.$broadcast('resetResettables');
}
} else {
unsavedWarningsConfig.log("user doesn't care about loosing stuff");
$rootScope.$broadcast('resetResettables');
unsavedWarningsConfig.log("all forms are clean");
}
} else {
unsavedWarningsConfig.log("all forms are clean");
}

});
removeFunctions.push(removeFn);
});
Expand Down Expand Up @@ -274,11 +280,11 @@ angular.module('unsavedChanges', ['resettable'])
// do things like reset validation, present messages, etc.
formElement.bind('reset', function(event) {
event.preventDefault();
// trigger resettables within this form or element

// trigger resettables within this form or element
var resettables = angular.element(formElement[0].querySelector('[resettable]'));
if(resettables.length) {
scope.$apply(resettables.triggerHandler('resetResettables'));
scope.$apply(resettables.triggerHandler('resetResettables'));
}

// sets for back to valid and pristine states
Expand Down Expand Up @@ -308,7 +314,7 @@ angular.module('unsavedChanges', ['resettable'])
* --------------------------------------------
*
* @note we don't create a seperate scope so the model value
* is still available onChange within the controller scope.
* is still available onChange within the controller scope.
* This fixes https://github.com/facultymatt/angular-unsavedChanges/issues/19
*
*/
Expand Down
2 changes: 1 addition & 1 deletion dist/unsavedChanges.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading