fix resolution profile not applied in ros_topic_converter #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ros_topic_converterwith a non-zero resolution, the resolutionparameter had no effect on the compressed output. This happened because
encoding_infowas computed beforeapplyResolutionProfile()modifiedpc_info.fields, so the compression remained effectively reversible evenwhen a non-zero resolution was specified.
This PR applies the resolution profile before computing
encoding_info,so
encoding_inforeflects the updated field resolutions.Changes
Before:
After:
Testing
resolution = 0.001(default) andresolution = 0.01Before this patch:
After this patch: