Fix Edge Case when iter is at MAX_ITER

[johnanthonyjose]

Context:
I used ConstantParamScheduler as my baseline scheduler in a detectron2-based repository.

For example: cfg.SOLVER.MAX_ITER = 80,000

When self.iter is at 79,999 and triggers after_step(), it will display a runtime error as shown below:

RuntimeError: Invalid where parameter for scheduler: 1.0

I've learned that it's due to the fact that the self.last_epoch of the scheduler is always ahead by 1 relative to self.iter of the trainer.

To resolve this, by reducing where by self.EPSILON_WHERE, the result value becomes 0.999999.

[facebook-github-bot]

Hi @johnanthonyjose!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!