-
Notifications
You must be signed in to change notification settings - Fork 50.2k
[wip] experiment to entangle less often #35392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Comparing: 65eec42...289a320 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
| // TODO: why does it render again? | ||
| ...(gate('enableParallelTransitions') | ||
| ? ['Suspend! [C]', 'Loading...'] | ||
| : []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM - Test accommodates unexpected behavior with TODO
Category: testing
Description:
Test includes conditional assertions with TODO comment 'why does it render again?' - accommodating unexplained re-renders
Suggestion:
Investigate why the extra render occurs and either fix the issue, document why it's expected, or track as a known issue separately
Confidence: 85%
Rule: test_accommodates_unexpected_behavior
| // TODO: why does it render again? | ||
| ...(gate('enableParallelTransitions') | ||
| ? [ | ||
| 'Suspend! [A]', | ||
| // pre-warming | ||
| 'B', | ||
| // end pre-warming | ||
| 'Loading...', | ||
| ] | ||
| : []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM - Test accommodates unexpected behavior with TODO
Category: testing
Description:
Test includes conditional assertions with TODO comment 'why does it render again?' - accommodating unexplained re-renders
Suggestion:
Investigate why the extra render occurs and either fix the issue, document why it's expected, or track as a known issue separately
Confidence: 85%
Rule: test_accommodates_unexpected_behavior
| // TODO: why does it render again? | ||
| ...(gate('enableParallelTransitions') | ||
| ? ['Suspend! [B]', 'Loading...'] | ||
| : []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM - Test accommodates unexpected behavior with TODO
Category: testing
Description:
Test includes conditional assertions with TODO comment 'why does it render again?' - accommodating unexplained re-renders
Suggestion:
Investigate why the extra render occurs and either fix the issue, document why it's expected, or track as a known issue separately
Confidence: 85%
Rule: test_accommodates_unexpected_behavior
|
@diffray-bot thanks, you've been banned. |
No description provided.