Skip to content

Conversation

@rickhanlonii
Copy link
Member

No description provided.

@meta-cla meta-cla bot added the CLA Signed label Dec 19, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Dec 19, 2025
@react-sizebot
Copy link

Comparing: 65eec42...289a320

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 607.60 kB 607.60 kB = 107.53 kB 107.53 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 666.83 kB 666.83 kB = 117.42 kB 117.41 kB
facebook-www/ReactDOM-prod.classic.js +0.02% 692.91 kB 693.03 kB +0.02% 121.92 kB 121.95 kB
facebook-www/ReactDOM-prod.modern.js +0.02% 683.34 kB 683.46 kB +0.02% 120.31 kB 120.33 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 289a320

Comment on lines +879 to +882
// TODO: why does it render again?
...(gate('enableParallelTransitions')
? ['Suspend! [C]', 'Loading...']
: []),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM - Test accommodates unexpected behavior with TODO
Category: testing

Description:
Test includes conditional assertions with TODO comment 'why does it render again?' - accommodating unexplained re-renders

Suggestion:
Investigate why the extra render occurs and either fix the issue, document why it's expected, or track as a known issue separately

Confidence: 85%
Rule: test_accommodates_unexpected_behavior

Comment on lines +639 to +648
// TODO: why does it render again?
...(gate('enableParallelTransitions')
? [
'Suspend! [A]',
// pre-warming
'B',
// end pre-warming
'Loading...',
]
: []),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM - Test accommodates unexpected behavior with TODO
Category: testing

Description:
Test includes conditional assertions with TODO comment 'why does it render again?' - accommodating unexplained re-renders

Suggestion:
Investigate why the extra render occurs and either fix the issue, document why it's expected, or track as a known issue separately

Confidence: 85%
Rule: test_accommodates_unexpected_behavior

Comment on lines +1040 to +1043
// TODO: why does it render again?
...(gate('enableParallelTransitions')
? ['Suspend! [B]', 'Loading...']
: []),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM - Test accommodates unexpected behavior with TODO
Category: testing

Description:
Test includes conditional assertions with TODO comment 'why does it render again?' - accommodating unexplained re-renders

Suggestion:
Investigate why the extra render occurs and either fix the issue, document why it's expected, or track as a known issue separately

Confidence: 85%
Rule: test_accommodates_unexpected_behavior

@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@facebook facebook deleted a comment from diffray-bot Dec 22, 2025
@rickhanlonii
Copy link
Member Author

@diffray-bot thanks, you've been banned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants