[lexical-link] Bug Fix: $toggleLink removes link when selection is collapsed #8138
+45
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senasiko
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
meta-cla
bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Feb 12, 2026
Comment on lines
688
to
693
| if (selection.isCollapsed()) { | ||
| parentLink.getChildren().forEach((child) => { | ||
| parentLink.insertBefore(child); | ||
| }); | ||
| parentLink.remove(); | ||
| } else { |
Collaborator
There was a problem hiding this comment.
it would probably be better to handle this outside of the nodes.forEach loop
Contributor
Author
There was a problem hiding this comment.
I made this change, please review again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixs an issue where, when the selection is collapsed, $toggleLink only affects the nearest TextNode
Before
before.mp4
After
after.mp4