Skip to content

Conversation

@StyleT
Copy link
Contributor

@StyleT StyleT commented Apr 19, 2024

This adds interactive editor picker for Lexical extension

Most of the changes are coming from this library fork https://github.com/hmarr/pick-dom-element (as it was lacking a feature proposed in hmarr/pick-dom-element#6)

Screen.Recording.2024-04-18.at.8.49.11.PM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2024
@vercel
Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:16pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:16pm

@StyleT StyleT marked this pull request as ready for review April 19, 2024 00:52
@StyleT StyleT force-pushed the feature/devtools_better_ui branch 2 times, most recently from a182f6b to 5d2855c Compare April 19, 2024 02:11
@StyleT StyleT force-pushed the feature/devtools_editor_selection branch from 3936700 to a868824 Compare April 19, 2024 02:12
@StyleT StyleT force-pushed the feature/devtools_editor_selection branch from a868824 to d715d33 Compare April 19, 2024 19:16
@StyleT StyleT changed the base branch from feature/devtools_better_ui to feature/devtools_publising April 19, 2024 19:16
@StyleT StyleT changed the base branch from feature/devtools_publising to main April 22, 2024 15:11
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.65 KB (0%) 473 ms (0%) 127 ms (+103.96% 🔺) 600 ms
packages/lexical-rich-text/dist/LexicalRichText.js 33.84 KB (0%) 677 ms (0%) 183 ms (+11.65% 🔺) 860 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 33.81 KB (0%) 677 ms (0%) 205 ms (+12.54% 🔺) 881 ms

@StyleT StyleT merged commit 25b3579 into main Apr 23, 2024
@zurfyx zurfyx deleted the feature/devtools_editor_selection branch February 28, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants