fix(search-algolia): add HTML sanitization to prevent XSS in search results #11726
+289
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
This PR addresses a security vulnerability and code quality issue:
Security: The Algolia search theme was rendering HTML from search results using
dangerouslySetInnerHTMLwithout proper sanitization. While Algolia's search results are generally trusted, this creates a potential XSS vulnerability if:This PR adds comprehensive HTML sanitization to prevent XSS attacks while preserving search highlighting functionality, and modernizes deprecated JavaScript methods.
Test Plan
Security Testing
Created comprehensive test suite with 14 test cases covering:
<em>,<mark>,<strong>,<b>,<i>)<script>,<iframe>,<object>,<img>, etc.)onclick,onload,onerror, etc.)javascript:,data:URIs)Verification Steps