fix(theme-common): properly memoize attributeFilter in useMutationObs… #11718
+32
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
This PR addresses the TODO in
useMutationObserver.ts:The
useShallowMemoObjecthook only performs shallow comparison—it flattens object entries and compares values directly. This meansattributeFilter(an array) is compared by reference, not by value. If a caller passes a new array instance with the same contents on each render, the options will be considered "changed" and theMutationObserverwill be recreated unnecessarily.Solution
useShallowMemoArrayutility toreactUtils.tsxthat properly memoizes arrays by their element valuesuseMutationObserverto extract and memoizeattributeFilterseparately before combining it back with the rest of the optionsTest Plan
yarn test packages/docusaurus-theme-common