Skip to content

tests: check: fail checkstyle on formatting violations #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yaakov-stein wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

tests: check: fail checkstyle on formatting violations #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/developers/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ You are welcome to reach out to qde@naccy.de if you need help, or have any quest
To do
-----

* Enforce ``clang-format`` and ``clang-tidy`` on all source files.
* Remove the RPM ``x86_64`` macro `workaround <https://pagure.io/epel/issue/325>`_ from the Fedora ``bpfilter.spec``.
* Gate the documentation generate in Fedora's ``bpfilter.spec`` with a ``bcond``.
* Add support for CMake 4.0 and ``ninja``.
Expand Down
1 change: 1 addition & 0 deletions tests/check/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ add_test(NAME "check.checkstyle"
${CLANG_FORMAT_BIN}
--style=file:${CMAKE_SOURCE_DIR}/.clang-format
--dry-run
--Werror
${bf_srcs}
)

Expand Down
Loading