Bump GoogleTest to v1.13.0 #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76534898 |
Summary:
Following up {D76177075}.
GitHub build is failing in main because GoogleTest v1.8.0 doesn't support `REGISTER_TYPED_TEST_SUITE_P`.
Not bumping to v1.17 to be safe because v1.14.0+ requires C++14.
Pull Request resolved: facebook#29
Differential Revision: D76534898
|
This pull request was exported from Phabricator. Differential Revision: D76534898 |
facebook-github-bot
pushed a commit
to facebook/redex
that referenced
this pull request
Jun 13, 2025
Summary:
Following up {D76177075}.
GitHub build is failing in main because GoogleTest v1.8.0 doesn't support `REGISTER_TYPED_TEST_SUITE_P`.
Not bumping to v1.17 to be safe because v1.14.0+ requires C++14.
X-link: facebook/SPARTA#29
Reviewed By: arthaud
Differential Revision: D76534898
fbshipit-source-id: f9f2eb4c408050871480574b55fc261777f0348b
|
This pull request has been merged in 3509e98. |
facebook-github-bot
pushed a commit
to facebook/redex
that referenced
this pull request
Jun 13, 2025
Summary:
Following up {D76177075}.
GitHub build is failing in main because GoogleTest v1.8.0 doesn't support `REGISTER_TYPED_TEST_SUITE_P`.
Not bumping to v1.17 to be safe because v1.14.0+ requires C++14.
X-link: facebook/SPARTA#29
Reviewed By: arthaud
Differential Revision: D76534898
fbshipit-source-id: f9f2eb4c408050871480574b55fc261777f0348b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
GitHub build is failing in main because GoogleTest v1.8.0 doesn't support REGISTER_TYPED_TEST_SUITE_P.
Not bumping to v1.17 to be safe because v1.14.0+ requires C++14.
Differential Revision: D76534898