Skip to content

common: add #ifndef guard for PLDM_FW_UPDATE_TIMEOUT_MS to allow platform overrides #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Victor-Jhong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

common: add #ifndef guard for PLDM_FW_UPDATE_TIMEOUT_MS to allow platform overrides #2641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions common/service/pldm/pldm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ LOG_MODULE_REGISTER(pldm);
#define PLDM_MSG_MAX_RETRY 3
#endif

#ifndef PLDM_FW_UPDATE_TIMEOUT_MS
#define PLDM_FW_UPDATE_TIMEOUT_MS 30000
#endif

#define PLDM_FW_UPDATE_MAX_RETRY 3

#define PLDM_RESP_MSG_PROC_MUTEX_TIMEOUT_MS 500
Expand Down
1 change: 1 addition & 0 deletions meta-facebook/minerva-ag/src/platform/plat_def.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#define MAX_AUX_SENSOR_NAME_LEN 58

#define PLDM_MSG_TIMEOUT_MS 5000
#define PLDM_FW_UPDATE_TIMEOUT_MS 5000

#define DISABLE_SENSOR_RESP_DURING_FW_UPDATE

Expand Down