Skip to content

Conversation

@pabloyangWW
Copy link
Contributor

[Task Description]
This patch updates DIMM sensor naming convention to align with hardware configuration. The sensor names are modified from A0/A2/A4/A6 to A2/A3/A6/A7 to accurately reflect the actual DIMM slot positions on the motherboard.

[Motivation]
The original sensor naming (DIMMA0, DIMMA2, DIMMA4, DIMMA6) did not match the physical DIMM slot layout on GC2 platform. This caused confusion during system monitoring and debugging. The corrected naming (DIMMA2, DIMMA3, DIMMA6, DIMMA7) ensures sensor names correspond to actual hardware slots, improving maintainability and reducing potential misidentification of DIMM-related issues.

[Design]

  1. Modified DIMM temperature sensors via PECI (0x06, 0x07, 0x0A, 0x0B):

    • SENSOR_NUM_TEMP_DIMM_A2 (0x06): DIMM A2 channel 2
    • SENSOR_NUM_TEMP_DIMM_A3 (0x07): DIMM A3 channel 3
    • SENSOR_NUM_TEMP_DIMM_A6 (0x0A): DIMM A6 channel 6
    • SENSOR_NUM_TEMP_DIMM_A7 (0x0B): DIMM A7 channel 7 Using Intel PECI interface with pre-read handlers for DIMM presence check
  2. Modified DIMM PMIC power sensors (0x40-0x43):

    • SENSOR_NUM_PWR_DIMMA2_PMIC (0x40): DIMM A2 power
    • SENSOR_NUM_PWR_DIMMA3_PMIC (0x41): DIMM A3 power
    • SENSOR_NUM_PWR_DIMMA6_PMIC (0x42): DIMM A6 power
    • SENSOR_NUM_PWR_DIMMA7_PMIC (0x43): DIMM A7 power Using PMIC driver with proper initialization arguments

[Test Result]
Tested on GC2-ES platform, all DIMM sensors reporting correctly with proper naming :

root@bmc-oob:~# sensor-util server
server:
MB_INLET_TEMP_C (0x1) : 21.000 C | (ok)
MB_PCH_TEMP_C (0x4) : NA | (na)
MB_SOC_CPU_TEMP_C (0x5) : 34.000 C | (ok)
MB_DIMMA2_TEMP_C (0x6) : 28.000 C | (ok)
MB_DIMMA3_TEMP_C (0x7) : 27.000 C | (ok)
MB_DIMMA6_TEMP_C (0xA) : 28.000 C | (ok)
MB_DIMMA7_TEMP_C (0xB) : 27.000 C | (ok)
MB_E1S_TEMP_C (0xD) : NA | (na)
MB_HSC_TEMP_C (0xE) : 25.000 C | (ok)
MB_VR_VCCIN_TEMP_C (0xF) : 35.000 C | (ok)
MB_VR_FIVRA_TEMP_C (0x10) : 32.000 C | (ok)
MB_VR_EHV_TEMP_C (0x11) : 32.000 C | (ok)
MB_VR_VCCD_TEMP_C (0x12) : 35.000 C | (ok)
MB_VR_FAON_TEMP_C (0x13) : 35.000 C | (ok)
MB_SOC_THERMAL_MARGIN_C (0x14) : 44.000 C | (ok)
MB_SOC_TJMAX_C (0x15) : 78.000 C | (ok)
MB_ADC_P12V_STBY_VOLT_V (0x20) : 12.159 Volts | (ok)
MB_ADC_P3V3_STBY_VOLT_V (0x21) : 3.312 Volts | (ok)
MB_ADC_P1V05_PCH_VOLT_V (0x22) : 1.050 Volts | (ok)
MB_ADC_P3V_BAT_VOLT_V (0x23) : 3.120 Volts | (ok)
MB_ADC_P5V_STBY_VOLT_V (0x24) : 4.995 Volts | (ok)
MB_ADC_P12V_DIMM_VOLT_V (0x25) : 12.180 Volts | (ok)
MB_ADC_P1V2_STBY_VOLT_V (0x26) : 1.194 Volts | (ok)
MB_ADC_P1V8_STBY_VOLT_V (0x27) : 1.800 Volts | (ok)
MB_HSC_INPUT_VOLT_V (0x29) : 12.159 Volts | (ok)
MB_VR_VCCIN_VOLT_V (0x2A) : 1.620 Volts | (ok)
MB_VR_FIVRA_VOLT_V (0x2B) : 1.810 Volts | (ok)
MB_VR_EHV_VOLT_V (0x2C) : 1.790 Volts | (ok)
MB_VR_VCCD_VOLT_V (0x2D) : 1.141 Volts | (ok)
MB_VR_FAON_VOLT_V (0x2E) : 1.057 Volts | (ok)
MB_HSC_OUTPUT_CURR_A (0x30) : 19.550 Amps | (ok)
MB_VR_VCCIN_CURR_A (0x31) : 14.040 Amps | (ok)
MB_VR_FIVRA_CURR_A (0x32) : 3.720 Amps | (ok)
MB_VR_EHV_CURR_A (0x33) : 0.480 Amps | (ok)
MB_VR_VCCD_CURR_A (0x34) : 0.380 Amps | (ok)
MB_VR_FAON_CURR_A (0x35) : 5.720 Amps | (ok)
MB_SOC_PACKAGE_PWR_W (0x38) : 33.000 Watts | (ok)
MB_HSC_INPUT_PWR_W (0x39) : 243.040 Watts | (ok)
MB_VR_VCCIN_PWR_W (0x3A) : 14.100 Watts | (ok)
MB_VR_FIVRA_PWR_W (0x3C) : 6.840 Watts | (ok)
MB_VR_EHV_PWR_W (0x3D) : 0.912 Watts | (ok)
MB_VR_VCCD_PWR_W (0x3E) : 0.000 Watts | (ok)
MB_VR_FAON_PWR_W (0x3F) : 5.880 Watts | (ok)
MB_VR_DIMMA2_PMIC_PWR_W (0x40) : 0.280 Watts | (ok)
MB_VR_DIMMA3_PMIC_PWR_W (0x41) : 1.120 Watts | (ok)
MB_VR_DIMMA6_PMIC_PWR_W (0x42) : 0.700 Watts | (ok)
MB_VR_DIMMA7_PMIC_PWR_W (0x43) : 0.420 Watts | (ok)

[Task Description]
This patch updates DIMM sensor naming convention to align with hardware
configuration. The sensor names are modified from A0/A2/A4/A6 to A2/A3/A6/A7
to accurately reflect the actual DIMM slot positions on the motherboard.

[Motivation]
The original sensor naming (DIMMA0, DIMMA2, DIMMA4, DIMMA6) did not match
the physical DIMM slot layout on GC2 platform. This caused confusion during
system monitoring and debugging. The corrected naming (DIMMA2, DIMMA3, DIMMA6,
DIMMA7) ensures sensor names correspond to actual hardware slots, improving
maintainability and reducing potential misidentification of DIMM-related
issues.

[Design]
1. Modified DIMM temperature sensors via PECI (0x06, 0x07, 0x0A, 0x0B):
   - SENSOR_NUM_TEMP_DIMM_A2 (0x06): DIMM A2 channel 2
   - SENSOR_NUM_TEMP_DIMM_A3 (0x07): DIMM A3 channel 3
   - SENSOR_NUM_TEMP_DIMM_A6 (0x0A): DIMM A6 channel 6
   - SENSOR_NUM_TEMP_DIMM_A7 (0x0B): DIMM A7 channel 7
   Using Intel PECI interface with pre-read handlers for DIMM presence check

2. Modified DIMM PMIC power sensors (0x40-0x43):
   - SENSOR_NUM_PWR_DIMMA2_PMIC (0x40): DIMM A2 power
   - SENSOR_NUM_PWR_DIMMA3_PMIC (0x41): DIMM A3 power
   - SENSOR_NUM_PWR_DIMMA6_PMIC (0x42): DIMM A6 power
   - SENSOR_NUM_PWR_DIMMA7_PMIC (0x43): DIMM A7 power
   Using PMIC driver with proper initialization arguments

[Test Result]
Tested on GC2-ES platform, all DIMM sensors reporting correctly with
proper naming :

root@bmc-oob:~# sensor-util server
server:
MB_INLET_TEMP_C              (0x1) :  21.000 C     | (ok)
MB_PCH_TEMP_C                (0x4) : NA | (na)
MB_SOC_CPU_TEMP_C            (0x5) :  34.000 C     | (ok)
MB_DIMMA2_TEMP_C             (0x6) :  28.000 C     | (ok)
MB_DIMMA3_TEMP_C             (0x7) :  27.000 C     | (ok)
MB_DIMMA6_TEMP_C             (0xA) :  28.000 C     | (ok)
MB_DIMMA7_TEMP_C             (0xB) :  27.000 C     | (ok)
MB_E1S_TEMP_C                (0xD) : NA | (na)
MB_HSC_TEMP_C                (0xE) :  25.000 C     | (ok)
MB_VR_VCCIN_TEMP_C           (0xF) :  35.000 C     | (ok)
MB_VR_FIVRA_TEMP_C           (0x10) :  32.000 C     | (ok)
MB_VR_EHV_TEMP_C             (0x11) :  32.000 C     | (ok)
MB_VR_VCCD_TEMP_C            (0x12) :  35.000 C     | (ok)
MB_VR_FAON_TEMP_C            (0x13) :  35.000 C     | (ok)
MB_SOC_THERMAL_MARGIN_C      (0x14) :  44.000 C     | (ok)
MB_SOC_TJMAX_C               (0x15) :  78.000 C     | (ok)
MB_ADC_P12V_STBY_VOLT_V      (0x20) :  12.159 Volts | (ok)
MB_ADC_P3V3_STBY_VOLT_V      (0x21) :   3.312 Volts | (ok)
MB_ADC_P1V05_PCH_VOLT_V      (0x22) :   1.050 Volts | (ok)
MB_ADC_P3V_BAT_VOLT_V        (0x23) :   3.120 Volts | (ok)
MB_ADC_P5V_STBY_VOLT_V       (0x24) :   4.995 Volts | (ok)
MB_ADC_P12V_DIMM_VOLT_V      (0x25) :  12.180 Volts | (ok)
MB_ADC_P1V2_STBY_VOLT_V      (0x26) :   1.194 Volts | (ok)
MB_ADC_P1V8_STBY_VOLT_V      (0x27) :   1.800 Volts | (ok)
MB_HSC_INPUT_VOLT_V          (0x29) :  12.159 Volts | (ok)
MB_VR_VCCIN_VOLT_V           (0x2A) :   1.620 Volts | (ok)
MB_VR_FIVRA_VOLT_V           (0x2B) :   1.810 Volts | (ok)
MB_VR_EHV_VOLT_V             (0x2C) :   1.790 Volts | (ok)
MB_VR_VCCD_VOLT_V            (0x2D) :   1.141 Volts | (ok)
MB_VR_FAON_VOLT_V            (0x2E) :   1.057 Volts | (ok)
MB_HSC_OUTPUT_CURR_A         (0x30) :  19.550 Amps  | (ok)
MB_VR_VCCIN_CURR_A           (0x31) :  14.040 Amps  | (ok)
MB_VR_FIVRA_CURR_A           (0x32) :   3.720 Amps  | (ok)
MB_VR_EHV_CURR_A             (0x33) :   0.480 Amps  | (ok)
MB_VR_VCCD_CURR_A            (0x34) :   0.380 Amps  | (ok)
MB_VR_FAON_CURR_A            (0x35) :   5.720 Amps  | (ok)
MB_SOC_PACKAGE_PWR_W         (0x38) :  33.000 Watts | (ok)
MB_HSC_INPUT_PWR_W           (0x39) : 243.040 Watts | (ok)
MB_VR_VCCIN_PWR_W            (0x3A) :  14.100 Watts | (ok)
MB_VR_FIVRA_PWR_W            (0x3C) :   6.840 Watts | (ok)
MB_VR_EHV_PWR_W              (0x3D) :   0.912 Watts | (ok)
MB_VR_VCCD_PWR_W             (0x3E) :   0.000 Watts | (ok)
MB_VR_FAON_PWR_W             (0x3F) :   5.880 Watts | (ok)
MB_VR_DIMMA2_PMIC_PWR_W      (0x40) :   0.280 Watts | (ok)
MB_VR_DIMMA3_PMIC_PWR_W      (0x41) :   1.120 Watts | (ok)
MB_VR_DIMMA6_PMIC_PWR_W      (0x42) :   0.700 Watts | (ok)
MB_VR_DIMMA7_PMIC_PWR_W      (0x43) :   0.420 Watts | (ok)
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 11, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D88927879. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant