Conversation
|
supposed to be for issue #21 |
|
I think I accidentally clicked to close this PR before as I was creating it... |
|
note for the reviewer: there appears to be a bug in GTM template UI. When I tried to run tests for this it would say "Invalid Input" and not run any tests at all; but if I muted any random test it would run all tests successfully. I reported that to Google, so we'll see... but seems like a memory issue (setup+tests can only be so big?) |
| return { | ||
| id: prod.id, | ||
| quantity: prod.quantity | ||
| quantity: (prod.quantity || 1), |
There was a problem hiding this comment.
added a fallback of 1 for quantity for each item in contents array (quantity should always be at least 1...)
| id: prod.id, | ||
| quantity: prod.quantity | ||
| quantity: (prod.quantity || 1), | ||
| title: prod.name, |
There was a problem hiding this comment.
mapped properties title, item_price, and category from items name, price, and category properties
| \ mock\nlet success, failure;\nmock('injectScript', (url, onsuccess, onfailure)\ | ||
| \ => {\n success = onsuccess;\n failure = onfailure;\n onsuccess();\n});\n\n\ | ||
| mock('copyFromWindow', key => {\n if (key === 'fbq') return () => {};\n});" | ||
| \ [{\n id: 'i1',\n quantity: 1,\n title: 'n1',\n item_price:\ |
There was a problem hiding this comment.
updated test to include the additional properties
|
is anyone maintaining this repo? looks like the last commit was in Nov 2020 from @sahava... nothing since facebook incubator took over? |
2 participants
No description provided.