Open
Conversation
KJeffree
force-pushed
the
update-to-09-09-2021-master
branch
from
805c9ed to
827b180
Compare
dmorgan-fa
requested changes
Sep 9, 2021
dmorgan-fa
left a comment
dmorgan-fa
left a comment
There was a problem hiding this comment.
Some small things that I've highlighted, but other than that nicely done 👍 Not an easy one to have tackled.
styles/bauhaus.css
Outdated
| border-top: 5px solid #000; | ||
| padding: 0 1cm 1cm 1cm; | ||
| } | ||
| /*=========================== LAYOUT =========================*/ß |
There was a problem hiding this comment.
Trailing German character here that's been overlooked.
Suggested change
| /*=========================== LAYOUT =========================*/ß | |
| /*=========================== LAYOUT =========================*/ | |
styles/bauhaus.css
Outdated
| @@ -12,6 +17,7 @@ Created by Roan Lavery | |||
| } | |||
|
|
|||
| #invoice { | |||
There was a problem hiding this comment.
The legacy talaria has this line as #invoice.pagestyle {
styles/modernist.css
Outdated
| width: 18.3035714%; /* 164/896px */ | ||
| } | ||
|
|
||
| /*Push the main body down to counteract the absolute positioning */ |
There was a problem hiding this comment.
Inconsequential change, just changing for consistency
Suggested change
| /*Push the main body down to counteract the absolute positioning */ | |
| /* Push the main body down to counteract the absolute positioning */ |
styles/simple_print.css
Outdated
| */ | ||
|
|
||
| @page:first { | ||
| @page: first { |
There was a problem hiding this comment.
Is this space intentional? Comparing this to what's in master no space has been added.
Suggested change
| @page: first { | |
| @page:first { | |
styles/lola.css
Outdated
| padding:2px 0; | ||
| text-align:left; | ||
| } | ||
| #vat-total td, #vat-total th { |
There was a problem hiding this comment.
Separating these to their own lines
Suggested change
| #vat-total td, #vat-total th { | |
| #vat-total td, | |
| #vat-total th { |
styles/lola.css
Outdated
Comment on lines
266
to
268
| font-size:9pt; | ||
| padding:2px 0; | ||
| text-align:left; |
There was a problem hiding this comment.
Adding in spacing
Suggested change
| font-size:9pt; | |
| padding:2px 0; | |
| text-align:left; | |
| font-size: 9pt; | |
| padding: 2px 0; | |
| text-align: left; |
The CSS in these style sheets have not been updated to match the styling added to the css style sheets in-app. These changes include adding more control over width and padding, adjusting margins, and so on. This will help to provide customers with accurate representations of the themes we provide in-app.
KJeffree
force-pushed
the
update-to-09-09-2021-master
branch
from
3a74cab to
7be4830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CSS for all themes to become up to date with FreeAgent master as of 09/09/2021.
These changes include adding more control over width and padding and adjusting margins, as well as changing the hex codes of some colours to match those used in the main app.
Formatting of CSS files have also been updated for readability and consistency