Skip to content

fix(expandable): glitching animated expansion #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BalbinaK merged 1 commit into from
Sep 28, 2022
Merged

fix(expandable): glitching animated expansion #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/_helpers/expand-transition.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export function ExpandTransition({
const [removeElement, setRemoveElement] = useState(!show);
const expandableRef = useRef<HTMLDivElement>(null);
const isMounted = useRef(false);
const initialShow = useRef<boolean>(show === true);

function collapseElement(el: HTMLElement) {
collapse(el, () => setRemoveElement(true));
Expand Down Expand Up @@ -37,8 +38,15 @@ export function ExpandTransition({
}
}, [show]);

// Set initial style to prevent glitching bug
const initialStyle = !initialShow.current ? 'overflow-hidden h-0' : undefined;

return (
<div ref={expandableRef} aria-hidden={!show ? true : undefined}>
<div
className={initialStyle}
ref={expandableRef}
aria-hidden={!show ? true : undefined}
>
{removeElement ? null : children}
</div>
);
Expand Down
8 changes: 8 additions & 0 deletions packages/expandable/stories/Expandable.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ export const Animated = () => {
);
};

export const AnimatedExpanded = () => {
return (
<Expandable title="Animated box" expanded box info animated>
<h1>I am expandable</h1>
</Expandable>
);
};

export const Heading = () => {
return (
<Expandable title="I'm also a heading" headingLevel={1}>
Expand Down