Issue 23 health metrics #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 10, 2025 12:44
- Learnt how to load data from the platform - Loaded the list of sensors in the Twinair project - Looked at some test cases for known bad sensors - Implemented draft outlier detection - Implemented draft stuck value count - Implemented draft na rolling count - Implemented inference of sampling frequency
Utility functions that needn't be inside Device: - infer_sampling_rate - mode_count
- Calculate implausible ratio in a rolling window
- get_implausible_values function for deeper investigation
- Use standardized interface as in the other
Device.get_..._ratio(self, period, subset, ...)
added 13 commits
November 18, 2025 13:42
- Calculate outliers based on rate of increase - Change interface for _ratio() functions
Collaborator
|
@danimateos seems that this PR introduced a build error on python 3.9 (it seems like 3.10 and 3.11 are fine). The error is here: https://github.com/fablabbcn/smartcitizen-data/actions/runs/19734193545/job/56542116176#step:7:52 On one of the new accessory functions for health checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
This PR implements the basic metrics described in #23:
get_implausible_ratioget_outlier_ratioget_nan_ratioAs well as a detection for stuck values using the number of times the most frequent value is present:
get_top_value_ratioAll are implemented as a rolling calculation to detect problematic moments in the device's life and have a consistent interface.