Initial Implementation of the Normal rendering mode. #2811
+125
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
\ci fast |
mwestphal
reviewed
Jan 11, 2026
mwestphal
reviewed
Jan 11, 2026
mwestphal
reviewed
Jan 11, 2026
Meakk
reviewed
Jan 12, 2026
Meakk
reviewed
Jan 12, 2026
ArchiePayne
force-pushed
the
normal_rendering_mode
branch
from
4de79a4 to
ba33574
Compare
Meakk
requested changes
Jan 14, 2026
Member
|
That looks good. I've run the main CI but I think you will have to add a test to cover the warning. Let's see what the coverage check says. |
ArchiePayne
force-pushed
the
normal_rendering_mode
branch
from
8838220 to
7c6f3ab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2811 +/- ##
==========================================
- Coverage 96.73% 96.71% -0.02%
==========================================
Files 154 154
Lines 13256 13291 +35
==========================================
+ Hits 12823 12855 +32
- Misses 433 436 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwestphal
reviewed
Jan 26, 2026
| ngs.GlyphMapper->SetSourceConnection(arrowSource->GetOutputPort()); | ||
| ngs.GlyphMapper->SetOrientationModeToDirection(); | ||
| ngs.GlyphMapper->SetOrientationArray(vtkDataSetAttributes::NORMALS); | ||
| ngs.GlyphMapper->SetScaleFactor(0.2); |
Member
There was a problem hiding this comment.
should that depends on the bounds of the data ?
mwestphal
reviewed
Jan 26, 2026
| ngs.InputDataHasNormals = points->GetPointData()->GetNormals() != nullptr; | ||
|
|
||
| vtkNew<vtkArrowSource> arrowSource; | ||
| ngs.GlyphMapper->SetInputData(points); |
mwestphal
reviewed
Jan 26, 2026
| this->ColoringPointSpritesMappersConfigured = true; | ||
| } | ||
|
|
||
| //// Handle Normal Glyphs |
Member
There was a problem hiding this comment.
Suggested change
| //// Handle Normal Glyphs | |
| // Handle Normal Glyphs |
mwestphal
reviewed
Jan 26, 2026
|
|
||
| /** | ||
| * Set the visibility of the normal glyphs actor. | ||
| * It will only be shown if raytracing and volume, and Point Sprites are not enabled |
Member
There was a problem hiding this comment.
this comment is not super clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implement the Normal Rendering mode, displaying arrows on top of the geometry to depict vertex normals.
Added option
--normal-glyphswith bindingctrl+nto toggle on/off.Added auto-test for the functionality.
Issue ticket number and link if any
Issue #4
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.