Change mcp to call_tool before adding get_resource#9
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MCP template system by renaming the mcp() function to call_tool() and introduces a new get_resource() function for MCP resource access. The changes improve the API clarity by providing distinct functions for different MCP operations.
Key changes:
- Renamed
mcp()function tocall_tool()across all templates and documentation - Added new
get_resource()function for accessing MCP resources - Created comprehensive test coverage for the new resource functionality
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| engine/globals.py | Added create_mcp_resource_function and imported AnyUrl for resource handling |
| engine/init.py | Updated global function registration from mcp to call_tool and added get_resource |
| tests/templates/spec*.md | Renamed function calls from mcp() to call_tool() and added resource examples |
| tests/e2e/test_e2e.py | Added comprehensive test for MCP resource functionality |
| README.md | Updated documentation examples to use new function names |
| CLAUDE.md | Updated project documentation to reflect API changes |
| tests/README.md | Added usage examples for new resource functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| logging.error(f"Error fetching resource {resource_uri}: {e}") | ||
| return {} | ||
| pass | ||
|
|
There was a problem hiding this comment.
The pass statement at the end of the function is unnecessary and should be removed as it serves no purpose after the return statement.
Suggested change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.