-
Notifications
You must be signed in to change notification settings - Fork 0
Add basic interactive prompt mode to fill variables #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,10 @@ | ||||||||||||
| import questionary | ||||||||||||
|
|
||||||||||||
| # Add interactive prompt helpers using questionary that will collect values for | ||||||||||||
| # unspecified template variables. | ||||||||||||
|
|
||||||||||||
|
|
||||||||||||
| async def collect_var_value(var_name: str) -> str: | ||||||||||||
| """Collect a value for a variable using questionary.""" | ||||||||||||
|
|
||||||||||||
| return await questionary.text(f"Please provide a value for '{var_name}':").ask_async() | ||||||||||||
|
||||||||||||
| return await questionary.text(f"Please provide a value for '{var_name}':").ask_async() | |
| value = await questionary.text(f"Please provide a value for '{var_name}':").ask_async() | |
| if value is None: | |
| raise RuntimeError("Prompt cancelled by user. Aborting variable collection.") | |
| return value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #!/usr/bin/env python3 | ||
| """Test runner script that patches collect_var_value for e2e testing.""" | ||
| import asyncio | ||
| from unittest.mock import patch | ||
|
|
||
| from cxk import main | ||
|
|
||
|
|
||
| async def mock_collect_var_value(var_name: str) -> str: | ||
| """Mock implementation that returns predictable values based on variable name.""" | ||
| mock_values = { | ||
| "name": "John", | ||
| "age": "25", | ||
| "city": "New York", | ||
| "weather": '{"condition": "sunny", "temp": "75F"}', | ||
| "username": "testuser", | ||
| "user": "test_user" | ||
| } | ||
| return mock_values.get(var_name, f"mock_value_{var_name}") | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| # Patch collect_var_value before running main | ||
| with patch('commands.create_spec.collect_var_value', side_effect=mock_collect_var_value): | ||
| asyncio.run(main()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,9 @@ | |
|
|
||
| ## Ticket description | ||
|
|
||
| {{ ticket }} | ||
| {{ ticket.id }} | ||
|
|
||
| {{ ticket.description }} | ||
|
|
||
| ## Additional context | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition checking for JSON format is unsafe. If
raw_valueis None, callingraw_value.strip()will raise an AttributeError. The null check should also verify the value is a string.