Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements HTTP support for MCP (Model Context Protocol) servers, replacing the previous placeholder implementation with full functionality. The changes enable users to add HTTP-based MCP servers with optional custom headers and proper authentication handling.
Key changes:
- Added
HTTPServerConfigclass to handle HTTP server configuration - Implemented HTTP session management with OAuth authentication support
- Updated CLI to support header parameters for HTTP servers
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
mcp_client/config.py |
Adds HTTPServerConfig class and updates MCPServersConfig to support HTTP servers |
mcp_client/client_session_provider.py |
Updates get_streamablehttp_session to accept HTTPServerConfig and handle optional OAuth |
mcp_client/session_manager.py |
Adds HTTP server session initialization support |
commands/mcp.py |
Replaces placeholder HTTP handler with full implementation including header parsing |
cxk.py |
Adds --header CLI argument support for HTTP server configuration |
tests/e2e/test_e2e.py |
Updates tests to verify actual HTTP server functionality instead of placeholder |
tests/templates/spec9.md |
Adds new test template file (unrelated to HTTP support) |
mcp_client/__init__.py |
Exports HTTPServerConfig for external use |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+1
to
+8
| # Task Template | ||
|
|
||
| ## Issue description | ||
|
|
||
| {% set issue = call_tool('github', 'get_issue', {'issue_number': 17, 'owner': 'eyalzh', 'repo': 'browser-control-mcp'}) %} | ||
|
|
||
| ### Github Issue Description | ||
| {{ issue.body }} No newline at end of file |
There was a problem hiding this comment.
This template file appears unrelated to the HTTP support changes described in the PR title and should likely be in a separate commit or PR.
Suggested change
| # Task Template | |
| ## Issue description | |
| {% set issue = call_tool('github', 'get_issue', {'issue_number': 17, 'owner': 'eyalzh', 'repo': 'browser-control-mcp'}) %} | |
| ### Github Issue Description | |
| {{ issue.body }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.