Skip to content

Add http support#11

Merged
eyalzh merged 2 commits intomainfrom
add-http-support
Aug 26, 2025
Merged

Add http support#11
eyalzh merged 2 commits intomainfrom
add-http-support

Conversation

@eyalzh
Copy link
Owner

@eyalzh eyalzh commented Aug 26, 2025

No description provided.

@eyalzh eyalzh requested a review from Copilot August 26, 2025 11:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements HTTP support for MCP (Model Context Protocol) servers, replacing the previous placeholder implementation with full functionality. The changes enable users to add HTTP-based MCP servers with optional custom headers and proper authentication handling.

Key changes:

  • Added HTTPServerConfig class to handle HTTP server configuration
  • Implemented HTTP session management with OAuth authentication support
  • Updated CLI to support header parameters for HTTP servers

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mcp_client/config.py Adds HTTPServerConfig class and updates MCPServersConfig to support HTTP servers
mcp_client/client_session_provider.py Updates get_streamablehttp_session to accept HTTPServerConfig and handle optional OAuth
mcp_client/session_manager.py Adds HTTP server session initialization support
commands/mcp.py Replaces placeholder HTTP handler with full implementation including header parsing
cxk.py Adds --header CLI argument support for HTTP server configuration
tests/e2e/test_e2e.py Updates tests to verify actual HTTP server functionality instead of placeholder
tests/templates/spec9.md Adds new test template file (unrelated to HTTP support)
mcp_client/__init__.py Exports HTTPServerConfig for external use

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +1 to +8
# Task Template

## Issue description

{% set issue = call_tool('github', 'get_issue', {'issue_number': 17, 'owner': 'eyalzh', 'repo': 'browser-control-mcp'}) %}

### Github Issue Description
{{ issue.body }} No newline at end of file
Copy link

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template file appears unrelated to the HTTP support changes described in the PR title and should likely be in a separate commit or PR.

Suggested change
# Task Template
## Issue description
{% set issue = call_tool('github', 'get_issue', {'issue_number': 17, 'owner': 'eyalzh', 'repo': 'browser-control-mcp'}) %}
### Github Issue Description
{{ issue.body }}

Copilot uses AI. Check for mistakes.
@eyalzh eyalzh merged commit 446e326 into main Aug 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant