-
Notifications
You must be signed in to change notification settings - Fork 0
feat: update changes yaml spec for latest ISO 10303 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| === Schema change | ||
|
|
||
| This example shows schema changes made to a resource schema, | ||
| `support_resource_schema` across two editions: version 2 and version 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two editions of the containing document:
note: The document edition and schema version are different scope and context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TRThurman I don't quite understand. This content directly comes from STEPmod at WG 12: data/resource_docs/fundamentals_of_product_description_and_support/resource.xml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, the document changes are considered different from schema and mapping changes.
Our ELF 5005 only deals with schema and mapping changes because they pertain to EXPRESS.
It will not deal with document changes, that would have to be somewhere else.
TRThurman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits.
|
@TRThurman one more question. Express Engine generates a structure like this: <schema.changes>
<!-- Express Engine -->
<!-- 5.2.7 (GIT eeng-5.2.7) -->
<!-- Steel Bank CL 2.5.8 (Unknown Bits) -->
<!-- Reference_Schema: GEOMETRY_SCHEMA -->
<!-- Path: /Users/mulgogi/src/mn/iso-10303/schemas/resources/geometry_schema/geometry_schema_v11.exp -->
<!-- Trial_schema: GEOMETRY_SCHEMA -->
<!-- Path: /Users/mulgogi/src/mn/iso-10303/schemas/resources/geometry_schema/geometry_schema_v13.exp -->
<schema.modifications>
<modified.object type="ENTITY" name="b_spline_curve_with_knots">
<description>
WHERE 'WR1' expression changed
</description>
</modified.object>
<modified.object type="ENTITY" name="rational_b_spline_surface">
<description>
<ul>
<li>DERIVE 'weights' type changed</li>
<li>DERIVE 'weights' expression changed</li>
</ul>
</description>
</modified.object>
<modified.object type="ENTITY" name="rational_b_spline_volume">
<description>
<ul>
<li>DERIVE 'weights' type changed</li>
<li>DERIVE 'weights' expression changed</li>
</ul>
</description>
</modified.object>
</schema.modifications>
</schema.changes>Should we handle the If we do this, I'll update the change migration once more. |
Should we handle the |
|
Excellent! I will also normalize "interfaced_items" because there are instances when there are more than one. |
|
I also want to add a YAML schema for this in the annex, this way we can reference it for validation of files in the repositories. I wonder where is the best place to put the schemas... maybe I put them in a new repository called "schemas ". |
Maybe: 10303-support-schemata? |
…cription more granular
4201db3 to
53e17b2
Compare
|
Merging this first, new changes can come in a new PR. I want to get the "schemas" repo going. Thanks @TRThurman ! |
|
I have also applied these schemas to the ISO 10303 branch I was working on, now they all validate nicely in VSCode! (The schemas are automatically retrieved by VSCode) |

No description provided.