fix(build): Use "umd" as library target for libraries#43
Open
nanovazquez wants to merge 1 commit intomasterfrom
Open
fix(build): Use "umd" as library target for libraries#43nanovazquez wants to merge 1 commit intomasterfrom
nanovazquez wants to merge 1 commit intomasterfrom
Conversation
49124cb to
5b3f005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today when installing the packages in a web app, we are getting this error:
This could be caused by multiple reasons, and sadly we cannot reproduce it locally through
npm link. This PR tries to fix the issue by:commonjs2toumd, ascommonjsusesrequire()to load dependencies.web(althoughwebis the default value). This is to let Webpack know that the environment is a browser and thus, therequire()function is not available.