Skip to content

[sc-158769] fixed deployment logs command #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
habfast merged 2 commits into from
Jan 8, 2026
Merged

[sc-158769] fixed deployment logs command #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2219fe
[sc-158769] fixed deployment logs command
habfast Jan 7, 2026
cd84e8e
[sc-147338] showing error details of deployment
habfast Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- dedicated-inference: ability to define the inference engine parameters, and to have some help around that

### Bug fixes

- dedicated-inference: get deployment logs command fixed

## 1.89.0

### Bug fixes
Expand Down
7 changes: 6 additions & 1 deletion cmd/aiservices/deployment/deployment_actions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,12 @@ func newDepActionsServer(t *testing.T) *depActionsServer {
return
}
if len(parts) == 2 && parts[1] == "logs" && r.Method == http.MethodGet {
writeJSON(t, w, http.StatusOK, v3.GetDeploymentLogsResponse("l1\nl2"))
writeJSON(t, w, http.StatusOK, v3.GetDeploymentLogsResponse{
Logs: []v3.GetDeploymentLogsEntry{
{Message: "l1"},
{Message: "l2"},
},
})
return
}
w.WriteHeader(http.StatusNotFound)
Expand Down
4 changes: 3 additions & 1 deletion cmd/aiservices/deployment/deployment_logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ func (c *DeploymentLogsCmd) CmdRun(_ *cobra.Command, _ []string) error {
}

if !globalstate.Quiet {
fmt.Fprintln(os.Stdout, string(*resp))
for _, entry := range resp.Logs {
fmt.Fprintln(os.Stdout, entry.Message)
}
return nil
}
// When quiet, do nothing
Expand Down
2 changes: 2 additions & 0 deletions cmd/aiservices/deployment/deployment_show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ type DeploymentShowOutput struct {
ID v3.UUID `json:"id"`
Name string `json:"name"`
Status v3.GetDeploymentResponseStatus `json:"status"`
StatusDetails string `json:"status_details"`
GPUType string `json:"gpu_type"`
GPUCount int64 `json:"gpu_count"`
Replicas int64 `json:"replicas"`
Expand Down Expand Up @@ -81,6 +82,7 @@ func (c *DeploymentShowCmd) CmdRun(_ *cobra.Command, _ []string) error {
ID: resp.ID,
Name: resp.Name,
Status: resp.Status,
StatusDetails: resp.StatusDetails,
GPUType: resp.GpuType,
GPUCount: resp.GpuCount,
Replicas: resp.Replicas,
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/s3 v1.2.0
github.com/aws/smithy-go v1.1.0
github.com/dustin/go-humanize v1.0.1
github.com/exoscale/egoscale/v3 v3.1.33
github.com/exoscale/egoscale/v3 v3.1.34-0.20260107090256-18aa51606080
github.com/exoscale/openapi-cli-generator v1.2.0
github.com/fatih/camelcase v1.0.0
github.com/hashicorp/go-multierror v1.1.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ github.com/envoyproxy/go-control-plane v0.9.10-0.20210907150352-cf90f659a021/go.
github.com/envoyproxy/go-control-plane v0.10.1/go.mod h1:AY7fTTXNdv/aJ2O5jwpxAPOWUZ7hQAEvzN5Pf27BkQQ=
github.com/envoyproxy/protoc-gen-validate v0.1.0/go.mod h1:iSmxcyjqTsJpI2R4NaDN7+kN2VEUnK/pcBlmesArF7c=
github.com/envoyproxy/protoc-gen-validate v0.6.2/go.mod h1:2t7qjJNvHPx8IjnBOzl9E9/baC+qXE/TeeyBRzgJDws=
github.com/exoscale/egoscale/v3 v3.1.33 h1:5Lk/pwZ+K0sjNu9obS0VYPfhZQffRkvvO0BpdPoir4o=
github.com/exoscale/egoscale/v3 v3.1.33/go.mod h1:0iY8OxgHJCS5TKqDNhwOW95JBKCnBZl3YGU4Yt+NqkU=
github.com/exoscale/egoscale/v3 v3.1.34-0.20260107090256-18aa51606080 h1:oQptChlHoTy/rh/hoDmmH4hLGMZ7Qp/N2jdOaeIkBQo=
github.com/exoscale/egoscale/v3 v3.1.34-0.20260107090256-18aa51606080/go.mod h1:0iY8OxgHJCS5TKqDNhwOW95JBKCnBZl3YGU4Yt+NqkU=
github.com/exoscale/openapi-cli-generator v1.2.0 h1:xgTff1bInBP+JZCauD7Jq9GNBFoKK31Cnv5FIAcxtrk=
github.com/exoscale/openapi-cli-generator v1.2.0/go.mod h1:TZBnbT7f3hJ5ImyUphJwRM+X5xF/zCQZ6o8a42gQeTs=
github.com/fatih/camelcase v1.0.0 h1:hxNvNX/xYBp0ovncs8WyWZrOrpBNub/JfaMvbURyft8=
Expand Down
18 changes: 17 additions & 1 deletion vendor/github.com/exoscale/egoscale/v3/schemas.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ github.com/dlclark/regexp2/syntax
# github.com/dustin/go-humanize v1.0.1
## explicit; go 1.16
github.com/dustin/go-humanize
# github.com/exoscale/egoscale/v3 v3.1.33
# github.com/exoscale/egoscale/v3 v3.1.34-0.20260107090256-18aa51606080
## explicit; go 1.23.8
github.com/exoscale/egoscale/v3
github.com/exoscale/egoscale/v3/credentials
Expand Down