fix: Add placeholder page when the user accesses another user's personal drive - EXO-82012

[MayTekayaa]

Before this change, a user who was a member of a space wanted to open a document location. He was redirected to the placeholder page and found that he cannot access the document location, which was incorrect since he had access to this document, which was not located in another user's personal drive.
This change corrects this behavior by setting the canAccess property to true to give access to all documents in the space located outside a user's personal drive, as is the case on prod now.

[rdenarie]

The description provided in the commit message do not correspond to the expected behaviour in the task :
In the commit message, you say that the placeholder page is incorrect
In the task, the placeholder is the expected behaviour.

Can you double what is wanted ?

In addition, setting canAccesDocument to true, without any permission check seems not a good practise

[MayTekayaa]

The description provided in the commit message do not correspond to the expected behaviour in the task : In the commit message, you say that the placeholder page is incorrect In the task, the placeholder is the expected behaviour.

Can you double what is wanted ?

In addition, setting canAccesDocument to true, without any permission check seems not a good practise

It is true that in this task, the placeholder is the expected behavior but after the change this page also appears for other documents in the space that are not located on another user's personal drive.
The modification should therefore display the restricted page only when the document is linked to a personal drive.

[rdenarie]

I'm sorry, but I do not understand the fix. Please plan a call with me to discuss about.
Thanks

[sonarqubecloud]

Quality Gate failed

Failed conditions
36.1% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube Cloud

[rdenarie]

@MayTekayaa
canAccess property is a property meaning : does the user have access to the document path
canAccessDocumentLocation is a property meaning : does the user can open a file explorer on the document path

It is 2 different properties, and we need to keep canAccess. You cannot rename it. I think that canAccessDocumentLocation must be a new property

[rdenarie]

@MayTekayaa
canAccess property is a property meaning : does the user have access to the document path
canAccessDocumentLocation is a property meaning : does the user can open a file explorer on the document path

It is 2 different properties, and we need to keep canAccess. You cannot rename it. I think that canAccessDocumentLocation must be a new property