Skip to content

#67 extend unit test #67 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkilias merged 3 commits into from
Sep 9, 2025
Merged

#67 extend unit test #67 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dafd6f4
extend unit test #67
jana-selva Sep 4, 2025
a1973bb
poetry run nox -s project:format
jana-selva Sep 4, 2025
8578900
Apply suggestion from @tkilias
jana-selva Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/changes/unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@
## Internal

* #68 Update to poetry 2.1.2 and exasol-toolbox 1.1.0
* Update transitive dependencies
* Update transitive dependencies
* #67 Extend unit test to contain test scenarios with different values for the parameter description
3 changes: 2 additions & 1 deletion exasol/error/_parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,11 @@ def _validate_parameter_values(self, parameter_node: ast.Dict, file: str) -> boo
Checks if value of ast dictionary are of expected type.
If the values are of expected type, the method returns True, otherwise False.
"""

ret_val = True
for value in parameter_node.values:
if isinstance(value, ast.Call):
if len(value.args) < 2:
value.args.append(ast.Constant(value=None))
description = value.args[1]
if not self._check_node_type(
ast.Constant, description, "description", file
Expand Down
252 changes: 252 additions & 0 deletions test/unit/cli_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,96 @@
)
],
),
(
cleandoc(
"""
from exasol import error

error1 = error.ExaError(
"E-TEST-1",
"this is an error",
["no mitigation available"],
{"param": error.Parameter("value", "")},
)
"""
),
[
ErrorCodeDetails(
identifier="E-TEST-1",
message="this is an error",
messagePlaceholders=[
Placeholder(placeholder="param", description="")
],
description=None,
internalDescription=None,
potentialCauses=None,
mitigations=["no mitigation available"],
sourceFile="<Unknown>",
sourceLine=3,
contextHash=None,
)
],
),
(
cleandoc(
"""
from exasol import error

error1 = error.ExaError(
"E-TEST-1",
"this is an error",
["no mitigation available"],
{"param": error.Parameter("value", None)},
)
"""
),
[
ErrorCodeDetails(
identifier="E-TEST-1",
message="this is an error",
messagePlaceholders=[
Placeholder(placeholder="param", description="")
],
description=None,
internalDescription=None,
potentialCauses=None,
mitigations=["no mitigation available"],
sourceFile="<Unknown>",
sourceLine=3,
contextHash=None,
)
],
),
(
cleandoc(
"""
from exasol import error

error1 = error.ExaError(
"E-TEST-1",
"this is an error",
["no mitigation available"],
{"param": error.Parameter("value")},
)
"""
),
[
ErrorCodeDetails(
identifier="E-TEST-1",
message="this is an error",
messagePlaceholders=[
Placeholder(placeholder="param", description="")
],
description=None,
internalDescription=None,
potentialCauses=None,
mitigations=["no mitigation available"],
sourceFile="<Unknown>",
sourceLine=3,
contextHash=None,
)
],
),
],
)
def test_ErrorCollector_error_definitions(src, expected):
Expand Down Expand Up @@ -211,6 +301,96 @@ def test_ErrorCollector_error_definitions(src, expected):
)
],
),
(
cleandoc(
"""
from exasol import error
from exasol.error import Parameter

var = input("description: ")

error1 = error.ExaError(
"E-TEST-1",
var,
["mitigations"],
{"param": Parameter("value", "")},
)
"""
),
[
Error(
code=INVALID_ERROR_CODE_DEFINITION.identifier,
message=INVALID_ERROR_CODE_DEFINITION.message,
mitigations=INVALID_ERROR_CODE_DEFINITION.mitigations,
parameters={
"error_element": "message",
"file": "<Unknown>",
"line": "8",
"defined_type": f"<class '{AST_NAME_CLASS}'>",
},
)
],
),
(
cleandoc(
"""
from exasol import error
from exasol.error import Parameter

var = input("description: ")

error1 = error.ExaError(
"E-TEST-1",
var,
["mitigations"],
{"param": Parameter("value", None)},
)
"""
),
[
Error(
code=INVALID_ERROR_CODE_DEFINITION.identifier,
message=INVALID_ERROR_CODE_DEFINITION.message,
mitigations=INVALID_ERROR_CODE_DEFINITION.mitigations,
parameters={
"error_element": "message",
"file": "<Unknown>",
"line": "8",
"defined_type": f"<class '{AST_NAME_CLASS}'>",
},
)
],
),
(
cleandoc(
"""
from exasol import error
from exasol.error import Parameter

var = input("description: ")

error1 = error.ExaError(
"E-TEST-1",
var,
["mitigations"],
{"param": Parameter("value")},
)
"""
),
[
Error(
code=INVALID_ERROR_CODE_DEFINITION.identifier,
message=INVALID_ERROR_CODE_DEFINITION.message,
mitigations=INVALID_ERROR_CODE_DEFINITION.mitigations,
parameters={
"error_element": "message",
"file": "<Unknown>",
"line": "8",
"defined_type": f"<class '{AST_NAME_CLASS}'>",
},
)
],
),
],
)
def test_ErrorCollector_errors(src, expected):
Expand Down Expand Up @@ -256,6 +436,78 @@ def test_ErrorCollector_errors(src, expected):
),
[],
),
(
cleandoc(
"""
from exasol import error
from exasol.error import Parameter

var = input("description: ")

error1 = error.ExaError(
"E-TEST-1",
"this is an error",
["no mitigation available"],
{"param": Parameter("value", "description")},
)
"""
),
[],
),
(
cleandoc(
"""
from exasol import error
from exasol.error import Parameter

var = input("description: ")

error1 = error.ExaError(
"E-TEST-1",
"this is an error",
["no mitigation available"],
{"param": Parameter("value", "")},
)
"""
),
[],
),
(
cleandoc(
"""
from exasol import error
from exasol.error import Parameter

var = input("description: ")

error1 = error.ExaError(
"E-TEST-1",
"this is an error",
["no mitigation available"],
{"param": Parameter("value", None)},
)
"""
),
[],
),
(
cleandoc(
"""
from exasol import error
from exasol.error import Parameter

var = input("description: ")

error1 = error.ExaError(
"E-TEST-1",
"this is an error",
["no mitigation available"],
{"param": Parameter("value")},
)
"""
),
[],
),
],
)
def test_ErrorCollector_warnings(src, expected):
Expand Down