Adding support for shrine name display #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macaddict42
commented
Jul 4, 2025
| var objectMagicProperties = entity.GetComponent<ObjectMagicProperties>(); | ||
|
|
||
| var mods = objectMagicProperties.Mods; | ||
| var mods = objectMagicProperties?.Mods; |
Author
There was a problem hiding this comment.
Encountered a null reference exception here where the HasComponent check returned true, but by the time it got to Entity.GetComponent, it was false.
Macaddict42
commented
Jul 4, 2025
| { | ||
| Content = | ||
| [ | ||
| new TextNode("Metadata/Shrines/Shrine") |
Author
There was a problem hiding this comment.
Since the Show() function checks for the entity being in AlwaysShownIngameIcons, need to add this for shrines to be shown.
Macaddict42
commented
Jul 4, 2025
| DeltaInWorldToMinimapDelta(iconGridPos - playerPos, | ||
| (playerHeight + GameController.IngameState.Data.GetTerrainHeightAt(iconGridPos)) * PoeMapExtension.WorldToGridConversion); | ||
|
|
||
| if (Settings.DrawShrineNames && icon.Entity.Type == EntityType.Shrine && !string.IsNullOrEmpty(icon.Entity.RenderName)) |
Author
There was a problem hiding this comment.
Added this after the Show() check but before the HasIngameIcon check so that we can add text to the existing ingame icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.