Open
Conversation
Contributor
|
Would you be able to take care of spec tests? I don't think removing the validations is the way to go, adding the comma to the regex seems to make more sense. Until puppet 4.0 (or parser = future) we won't be able to validate elements in an array so I've left stuff like that off until that becomes more adopted. |
Contributor
Author
|
spec tests: yeah, I really ought to get set up with that. Let me get myself set up, need to be able to start doing tests. I just started with Puppet and was mostly checking it out and making a proof of concept but at think at this point I'm settled on it so it's worth taking the time. email list: good point, validating for the comma make more sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'joe@example.org,bob@example.org'and it will send the email to both. I think it would be nicer if it was an array of string as you could then do validation but I couldn't figure out how to loop through an array in Puppet and I ran out of time for this.