Skip to content

Conversation

@evans22j
Copy link
Owner

@evans22j evans22j commented Aug 4, 2022

In this PR

  • Create an API endpoint to list all posts for a user.
  • Create an API endpoint to list all comments for a user's post.
  • Create an API endpoint to add a comment to a post. Remember that the owner of the comment is the user that makes it; it should not be set by passing a parameter.
  • Add authentication to your API endpoints.
  • Your API endpoints should receive JSON and respond JSON as well.

Copy link

@elisha2kyakpo1 elisha2kyakpo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 team,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • The PR title and description looks professional✔️
  • The readme file is well documented ✔️
  • You have descriptive commit messages ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines +3 to +6
def index
@users = User.all
render json: @users, status: :ok
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Devise expects an email and password for authentication or authorization, but the user's table doesn't have an email. Kindly fix the error that comes when you want to log in.

email

Copy link

@julie-ify julie-ify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team,

Highlights!

  • Good feature branch name ✔️
  • No linter errors ✔️
  • Descriptive pull request ✔️
  • Descriptive commit messages ✔️
  • Good code organization and working app ✔️
  • Descriptive README ✔️

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Status: Approved ✔️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants