Devise

[evans22j]

In this PR

• Remove current_user method in ApplicationController, devise will provide us with one.
• Install and setup devise.
  • Can register a new user.
  • User logs in with a combination of email and password.
  • Hashed password should be stored in the database.
  • Ask for confirmation of email.
  • Can reset password.
• Modify the views in devise for registration and login to match the wireframes from the Sneak Peek and the styling.

[sja-thedude]

Invalid Code Review Request ❌

Hi @evans22j, This is @sja-thedude your code reviewer.

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

You have submitted a project, that doesn't have commits from both members. As this project is pair programming, kindly make sure both contribute.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me [@sja-thedude] in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

[thecodechaser]

STATUS: CHANGES REQUIRED ♻️

Hi @evans22j, and @white3d👋,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To Highlight 🎉

• No linter errors. ✔️
• Gitflow is followed. ✔️
• Professional README file. ✔️
• PR has a good title and summary. ✔️

Required Changes ♻️

• You haven't configured devise in your project but you just added the devise files manually. Please add the devise gem to your Gemfile and configure the devise correctly.
  • I would suggest following the steps in this article, It will help you to install device in your project and configure it correctly Add devise in RoR project.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:
N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[dasileker]

Hi @evans22j,

Good job so far!

There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

• Linters are green ✅.
• PR is full of details 👌.
• The readme file is having all details 👌.

Required Changes ♻️

Check the comments under the review.

• Nice job on the devise project however, the app is having a problem with the devise.rb located in the config/initializer folder, it seems that you didn't add the devise gem you have added a file with codes instead. so please add a gem and follow the instructions from the curriculum.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

• N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[Lordkaito]

Hi @evans22j,

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.