oxidize transforms #663
Draft
oxidize transforms #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostvanzwieten
force-pushed
the
oxidize
branch
6 times, most recently
from
90493fd to
5ada4f8
Compare
joostvanzwieten
force-pushed
the
oxidize
branch
10 times, most recently
from
906dffc to
afe37e0
Compare
joostvanzwieten
force-pushed
the
oxidize
branch
from
afe37e0 to
c37c663
Compare
joostvanzwieten
force-pushed
the
oxidize
branch
from
1edd3fd to
31f900b
Compare
joostvanzwieten
force-pushed
the
oxidize
branch
from
794a3c8 to
2612ffb
Compare
The `WithDerivative` evaluable defines a derivative of a wrapped array to some target. The target is not included in the `Evaluable.dependencies`, but is included in the `Array.arguments`. The current default implementation of `Array._derivative` incorrectly returns zeros if the derivative target is not found in `self.dependencies`. This patch fixes the bug by testing for existence in `self.arguments`.
This patch changes the `transform_chains` part of the lower args from a list of `EvaluableTransformChain`s to a tuple of a list of transforms sequences (`transformseq.Transforms`) and an evaluable index (`Array`). The relevant operations defined on the `EvaluableTransformChains` are now defined as subclasses of `evaluable.Array`, taking (unevaluable) transforms sequences, the evaluable index and evaluable coordinates as constructor arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.