Parallel trim #656
Open
Parallel trim #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertjanvanzwieten
force-pushed
the
parallel-trim
branch
from
dce9047 to
2f7b68b
Compare
With `parallel.fork` data cannot be shared between processes using shared memory, except for arrays. `multiprocessing.Manager` supports sharing data via pipes or sockets using pickle as serialization. This patch adds a minimal subset of `multiprocessing.Manager` to `parallel`, supporting shared lists and dicts. If parallel mode is disabled, a fake manager is returned which creates regular lists and dicts, eliminating overhead of serialization, transfering and deserialization.
`Topology.trim` can be quite slow if the levelset is expensive and maxrefine is large. Although the work is embarrassingly parallel, this was not exploited, because we can't make a shared memory array of element.Reference objects. With the newly added `parallel.Manager` we have an alternative way of sharing data between processes: using pickle and pipes. This patch adds support for parallel trimming using the `parallel.Manager.list`.
gertjanvanzwieten
force-pushed
the
parallel-trim
branch
from
2f7b68b to
e20a066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parallelize Topology.trim