reuse sessions to eliminate fd leak #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Summary
Improves HTTP resource management to prevent FD leaks by reusing sessions and ensuring responses are closed.
requests.SessioninFireworksTracingAdapterandRemoteRolloutProcessor; wrap allGET/POSTcalls in context managers to auto-close responsesFireworksTracingAdapter.close()and call it fromRemoteRolloutProcessor.cleanup(); also close the processor's own session incleanupget_evaluation_rowsto parsedetailfrom proxy JSON and log precise messages/logsretrieval with fallback and normalized resultsWritten by Cursor Bugbot for commit aee4193. This will update automatically on new commits. Configure here.