Skip to content

Conversation

@xzrderek
Copy link
Contributor

@xzrderek xzrderek commented Jan 4, 2026

Note

Summary
Improves HTTP resource management to prevent FD leaks by reusing sessions and ensuring responses are closed.

  • Use a shared requests.Session in FireworksTracingAdapter and RemoteRolloutProcessor; wrap all GET/POST calls in context managers to auto-close responses
  • Add FireworksTracingAdapter.close() and call it from RemoteRolloutProcessor.cleanup(); also close the processor's own session in cleanup
  • Refine error handling in get_evaluation_rows to parse detail from proxy JSON and log precise messages
  • Minor adjustments to /logs retrieval with fallback and normalized results

Written by Cursor Bugbot for commit aee4193. This will update automatically on new commits. Configure here.

@xzrderek xzrderek requested a review from benjibc January 4, 2026 06:02
@xzrderek xzrderek enabled auto-merge (squash) January 5, 2026 18:44
@xzrderek xzrderek disabled auto-merge January 5, 2026 18:44
@xzrderek xzrderek merged commit a5b0060 into main Jan 5, 2026
17 of 18 checks passed
@xzrderek xzrderek deleted the derekx/reuse-session branch January 5, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants