Conversation
I add more intercepted functions so that the lava-m programs can properly get input tainted.
aurelf
left a comment
There was a problem hiding this comment.
Thanks for the PR, I added a few comments.
Also it would be great to add a test case, like extending test/file_input.c those are run by the CI and allow to detect regressions.
Thanks !
|
Some functions are difficult for me to write test cases for (like getutent). I’m still learing it. 😢 |
|
Thanks for the changes! Would be great if the test is possible to add for that function too... Do you think you can add it ? |
It may be a bit difficult for me now 😭 , I haven't figured out how symcc testing works yet. It would be great to have your help!. |
We have some documentation here: https://github.com/eurecom-s3/symcc/blob/master/docs/Testing.txt. Let us know if you have questions! |
|
Sorry for trouble but this PR does not seem to work in the current version of SymCC. Maybe a possible change is use |
I can take it over, but I've got a question about the symbolic version of I don't have a LAVA-M setup to check |
|
I'm trying to look at this PR, @Yhcrown in case you can give me push access to your branch that would save me quite some time :) It's quite manual now... I seem to be only able modify your pr from the online editor. |
|
Just curious, is this still being worked on? LAVA is currently in the process of being upgraded, and perhaps I can help with this. For now, LAVA is being upgraded to work with LLVM-11 and at least there is potentially a plan to have LAVA leverage symcc to be able to plant bugs in more places in code. |
Sorry for the late reply. This sounds interesting, but I am not currently pursuing work in this direction. You can discuss advancing this direction with the members here. |
I'm very sorry for such a late reply, I missed this notification before. I have added you as a collaborator, although it is quite late. I hope this may still be of help. |
fix #102.
I add more intercepted functions so that the lava-m programs can properly get input tainted.
If the code is not quite standardized, I hope to get your test and modification.
Thanks & Best regards.