-
Notifications
You must be signed in to change notification settings - Fork 25
Fix all Clippy warnings in etna_core #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix all Clippy warnings in etna_core #72
Conversation
Validation Successful!This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes. |
|
Thank you for opening this PR! Our automated system is currently verifying the PR requirements. |
|
Hi, I have implemented the requested changes. Please let me know if any further modifications are needed, and I will address them promptly. I have also attached the relevant screenshots for your reference. Best regards, |
debug-soham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Madhavi1108 Great work! Approved.
Aamod007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Madhavi1108 Great Work
|
Hi, |
|
@Madhavi1108 I appreciate your consideration, but for now Issue #39 is on hold, we will notify you when its open to work. |
|
@Madhavi1108 please resolve branch conflicts. |
Validation Successful!This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes. |
Removed commented-out code and improved code readability.
Validation Successful!This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes. |
Validation Successful!This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes. |
|
@Madhavi1108 some clingy fixes are required in the PR. |
|
Hi @Aamod007 , |
Validation Successful!This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes. |
|
Hi @Aamod007 , |
Aamod007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Madhavi1108 Build errors fixed, Ready to merge after CI. Great job! Appreciate your work !
Fixes
Closes: #50
Type of Change
Description
This pull request fixes all Clippy warnings in the Rust codebase.
Changes include:
How Has This Been Tested?
Screenshots / Logs
Cargo clippyTest resultsContribution Context