Skip to content

Conversation

@Madhavi1108
Copy link
Contributor

Fixes

Closes: #50

Type of Change

  • Bug fix
  • New feature
  • Documentation / Refactor
  • Math / Logic correction

Description

This pull request fixes all Clippy warnings in the Rust codebase.

Changes include:

  • Updated code to follow Rust idioms and Clippy recommendations.
  • Removed unused variables and imports.

How Has This Been Tested?

  • Unit Tests: All existing tests ran successfully.
  • Manual Testing: Verified that core Rust functionality behaves as expected.
  • Integration: Confirmed Rust core and Python API continue to communicate correctly.

Screenshots / Logs

Cargo clippy
image

Test results
image

Contribution Context

  • I am contributing through the SWOC program.

@github-actions
Copy link

Validation Successful!

This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes.

@github-actions
Copy link

Thank you for opening this PR! Our automated system is currently verifying the PR requirements.
Internal Discussion: Discord

@github-actions github-actions bot added area: rust-core Math, backprop, and Rust-based ML logic. Medium Requires good codebase knowledge. refactor Code cleanup and architectural improvements. labels Jan 31, 2026
@Madhavi1108
Copy link
Contributor Author

Hi,

I have implemented the requested changes. Please let me know if any further modifications are needed, and I will address them promptly.

I have also attached the relevant screenshots for your reference.

Best regards,
Madhavi

Copy link
Contributor

@debug-soham debug-soham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhavi1108 Great work! Approved.

@debug-soham debug-soham added the SWoC26 Contributions specifically for the Social Winter of Code program. label Feb 3, 2026
Copy link
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhavi1108 Great Work

@Madhavi1108
Copy link
Contributor Author

Hi,
Thanks for the review
Can the other issue 39 be assigned to me once this issue is closed?

@Aamod007
Copy link
Collaborator

Aamod007 commented Feb 9, 2026

@Madhavi1108 I appreciate your consideration, but for now Issue #39 is on hold, we will notify you when its open to work.

@Aamod007
Copy link
Collaborator

@Madhavi1108 please resolve branch conflicts.

@github-actions
Copy link

Validation Successful!

This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes.

Removed commented-out code and improved code readability.
@github-actions
Copy link

Validation Successful!

This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes.

@github-actions
Copy link

Validation Successful!

This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes.

@Aamod007
Copy link
Collaborator

@Madhavi1108 some clingy fixes are required in the PR.

@Madhavi1108
Copy link
Contributor Author

Hi @Aamod007 ,
I am working on it
As soon as i solve it i will update the pull request
Thanks for the patience

@github-actions
Copy link

Validation Successful!

This pull request has been verified and linked to issue #50. The system is now synchronizing metadata from the referenced issue. Kindly await maintainer review of your changes.

@Madhavi1108
Copy link
Contributor Author

Hi @Aamod007 ,
Thanks for the understanding.
I have made the changes.
Now the code is running without any warnings.
Any changes required I will be more than happy to do the same.

Copy link
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhavi1108 Build errors fixed, Ready to merge after CI. Great job! Appreciate your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: rust-core Math, backprop, and Rust-based ML logic. Medium Requires good codebase knowledge. refactor Code cleanup and architectural improvements. SWoC26 Contributions specifically for the Social Winter of Code program.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running cargo clippy in etna_core shows 30 warnings related to code style and Rust best practices.

3 participants