new ws url + deprecating old structure #65
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR introduces WebSocket RPC URL support and refactors the URL building structure. The changes deprecate the old URL field names (e.g., rpc_url, ipfs_url) while introducing a new naming convention (e.g., http_rpc, ws_rpc, explorer). The refactoring also simplifies function signatures by accepting Stack structs directly instead of individual slug and api_key parameters.
Key changes:
- Added WebSocket URL support with new
ws_rpcfield andws_rpc_url/1function - Refactored URL building functions to accept Stack structs instead of individual parameters
- Introduced new URL field naming convention while maintaining backward compatibility with deprecated fields
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # new ones | ||
| http_rpc: http_rpc_url(stack), | ||
| ws_rpc: ws_rpc_url(stack), |
There was a problem hiding this comment.
The new URL structure is incomplete. While the deprecated structure includes "ipfs_url", the new structure (lines 77-79) is missing an "ipfs" field. For consistency and feature parity, consider adding "ipfs: ipfs_url(stack)" to maintain all URL types in the new structure.
| ws_rpc: ws_rpc_url(stack), | |
| ws_rpc: ws_rpc_url(stack), | |
| ipfs: ipfs_url(stack), |
| # new ones | ||
| http_rpc: http_rpc_url(stack), | ||
| ws_rpc: ws_rpc_url(stack), | ||
| explorer: explorer_url(stack) |
There was a problem hiding this comment.
The new URL structure is missing graph-related URLs. While the deprecated structure conditionally includes "graph_url", "graph_rpc_url", and "graph_status", these are not represented in the new structure (lines 77-79). Consider adding corresponding new keys like "graph", "graph_rpc", and "graph_status" to the new structure when graph is enabled, to maintain feature parity.
No description provided.