Add use_non_matching_label option #518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngheloAlf
reviewed
Feb 10, 2026
Collaborator
AngheloAlf
left a comment
AngheloAlf
left a comment
There was a problem hiding this comment.
You need to mention the new attribute here https://github.com/ethteck/splat/blob/main/docs/Adding-Symbols.md
You also need to bump the min spimdisasm version to 1.40.0. It is defined in a few places like pyproject.toml, requirements.txt and
https://github.com/ethteck/splat/blob/main/src/splat/disassembler/spimdisasm_disassembler.py#L10, and maybe something else I'm missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds splat support for the spimdisasm option added in this PR Decompollaborate/spimdisasm#199
Please let me know if I need to update any sections of the documentation to accompany this change