GTE macros update #486
Closed
GTE macros update #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is no longer needed because rabbitizer no longer emits this extra argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the
dpctmacro ingte_macros.sintroduced by #481 seem to produce non matching builds on some other PSX games, meaning the exact garbage bits of this instruction are required.Because of this,
rabbitizernow added a new argument to this instruction exposing any of the garbage bits encoded on the actual binary on version 1.14.0 onwards Decompollaborate/rabbitizer#81 .This PR updates the definition of the
dpctmacro on the autogeneratedgte_macros.sfile