feat: op-signer: Necessary script adjustments [5/N] #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseguy
approved these changes
Aug 21, 2025
Collaborator
bitwiseguy
left a comment
bitwiseguy
left a comment
There was a problem hiding this comment.
Both of these scripts can be tested locally so if we ever decide to test these, it would be very easy.
Looks good, but since you mention adding tests would be easy, why not add them now?
Collaborator
Author
It would need to be a new kind of tests, nothing we have atm. I made this PR like a year or so ago, it introduces a bash testing capability #145 but it's not something urgent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the script for generating local credentials is adjusted to fit our usecase (unnecessary indirection is removed & file permissions are adjusted).
Additionally, an inline script from the original PR is moved into a shell script - this script converts a HEX private key to a PEM file. This is necessary since
op-signerrequires private keys (that we have in the deployment output in HEX) to be converted to PEM files.Both of these scripts can be tested locally so if we ever decide to test these, it would be very easy.