-
Notifications
You must be signed in to change notification settings - Fork 4
docs: improve ETHID MCP quick setup instructions #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Clarify that setup methods are options to choose from - Add Claude Code setup as the first option with simple command - Rename existing options for consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
@schmidsi is attempting to deploy a commit to the EFP Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughReorganized ETHID MCP Quick Setup into three options (Claude Code, Online Server, Local). Added explicit endpoints for SSE and HTTP. Updated commands, including a Claude CLI example and simplified local install to only npm install. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
pages/docs/ai-tools/ethid-mcp.mdx (3)
9-16: Standardize MCP server name to match the rest of the docsElsewhere (config JSON, Claude Desktop config, troubleshooting) the server is named “ethid-mcp”. Using “ethid” here will confuse users and break copy-paste consistency.
Apply this diff to align the name:
-```bash -claude mcp add --transport sse ethid https://ethid-mcp.efp.workers.dev/sse -``` +```bash +claude mcp add --transport sse ethid-mcp https://ethid-mcp.efp.workers.dev/sse +```Optional: consider titling the section “Claude Desktop/CLI Setup” to be explicit that this uses the Claude CLI.
17-27: Verify client list and tighten language for MCP compatibility“Wireshark” is a network analyzer, not an MCP client. “ChatGPT” also doesn’t natively support MCP. Safer wording avoids misleading examples.
Apply this diff to adjust the client list and code block language (URLs aren’t bash commands):
-Use one of the following endpoints to connect the MCP server to your AI assistant (Claude, Wireshark, ChatGPT, etc.). +Use one of the following endpoints to connect the MCP server to your MCP-compatible client (e.g., Claude Desktop).-```bash +```text # Using the SSE endpoint https://ethid-mcp.efp.workers.dev/sse # Or HTTP endpoint https://ethid-mcp.efp.workers.devIf you want, I can add a short, verified list of known MCP-compatible clients here. --- `29-34`: **Confirm local steps; summary says “npm install” only, but doc still includes “npm run dev”** The AI summary mentions simplifying local setup to only npm install, yet this section still includes npm run dev. If the intent is to keep both (recommended), nothing to change; if not, remove the second line to match the summary. Two alternatives: - Keep both (recommended for a runnable local setup): no change. - Or, to match the summary, remove the dev step: ```diff ```bash npm install -npm run devOptionally, consider adding a one-liner above with clone instructions for completeness (clone + cd) if users may land here directly. </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** **💡 Knowledge Base configuration:** - MCP integration is disabled by default for public repositories - Jira integration is disabled by default for public repositories - Linear integration is disabled by default for public repositories You can enable these sources in your CodeRabbit configuration. <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between a9d3bcbde7a95c617f10c228877853cc7b0c61df and e4380a84a51b78e72c4d93695532d4df0b1d5730. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `pages/docs/ai-tools/ethid-mcp.mdx` (2 hunks) </details> <details> <summary>🔇 Additional comments (1)</summary><blockquote> <details> <summary>pages/docs/ai-tools/ethid-mcp.mdx (1)</summary> `7-8`: **Good clarification that the methods are alternatives** The “Choose one of the following options…” line makes the branching setup paths explicit. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
🤖 Generated with Claude Code
Summary by CodeRabbit