Skip to content

Conversation

@jamesavechives
Copy link
Contributor

  • Clarify description: groups of Ethereum accounts (EOAs and contracts)
  • Expand Abstract with coordination/access control use cases and examples
  • Rewrite semantics as observable contract behavior (MUST revert conditions)
  • Allow owner leaveGroup to either revert or transfer ownership first
  • Add ERC-165 discoverability note for ownership transfer extension
  • Link reference implementation files
  • Remove RFC2119 keywords from Security Considerations (non-normative)
  • Fix assets README path reference

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

- Clarify description: groups of Ethereum accounts (EOAs and contracts)
- Expand Abstract with coordination/access control use cases and examples
- Rewrite semantics as observable contract behavior (MUST revert conditions)
- Allow owner leaveGroup to either revert or transfer ownership first
- Add ERC-165 discoverability note for ownership transfer extension
- Link reference implementation files
- Remove RFC2119 keywords from Security Considerations (non-normative)
- Fix assets README path reference
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 30, 2026

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Update ERC-8063 per reviewer feedback Update ERC-8063: Update ERC-8063 per reviewer feedback Jan 30, 2026
@eip-review-bot eip-review-bot enabled auto-merge (squash) January 30, 2026 08:46
eip-review-bot
eip-review-bot previously approved these changes Jan 30, 2026
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot added the w-ci label Jan 30, 2026
Major changes based on Ethereum Magicians review:
- Redefine Groups as ERC-20 tokens with balance capped at 1
- Require ERC-5679 for mint/burn instead of custom addMember/removeMember
- Remove owner() from interface, recommend ERC-173 for ownership
- Add canMint/canBurn for access control introspection
- Make group-friendly aliases (addMember, isMember, etc.) optional
- Remove redundant ERC8063ERC20.sol (ERC-20 is now the base)

This provides instant compatibility with existing wallets, explorers,
and tooling while maintaining the group membership semantics.
auto-merge was automatically disabled January 30, 2026 14:02

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) January 30, 2026 14:03
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot
eip-review-bot previously approved these changes Jan 30, 2026
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Credit @SamWilsn for significant design contributions during review.
Also update author name from James Savechives to Cheng Qian.
auto-merge was automatically disabled January 30, 2026 14:20

Head branch was pushed to by a user without write access

@github-actions github-actions bot removed the w-ci label Jan 30, 2026
@eip-review-bot eip-review-bot enabled auto-merge (squash) January 30, 2026 14:21
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot
eip-review-bot previously approved these changes Jan 30, 2026
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled January 30, 2026 14:24

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) January 30, 2026 14:25
eip-review-bot
eip-review-bot previously approved these changes Jan 30, 2026
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot added the w-ci label Jan 30, 2026
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, however the move of the files from the erc-8063 folder into the eip-8063 folder is not correct (should be inside the erc-8063 folder)

@jamesavechives
Copy link
Contributor Author

The changes look good, however the move of the files from the erc-8063 folder into the eip-8063 folder is not correct (should be inside the erc-8063 folder)

ok, done!

@github-actions
Copy link

The commit 7ed1ffc (as a parent of a054828) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Feb 11, 2026
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 11, 2026 01:59
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@jochem-brouwer
Copy link
Member

Ah, the CI is failing, that should be fixed!

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing and should be fixed

eip-review-bot
eip-review-bot previously approved these changes Feb 11, 2026
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Co-authored-by: Cursor <cursoragent@cursor.com>
auto-merge was automatically disabled February 11, 2026 05:36

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 11, 2026 05:37
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit b95e93d into ethereum:master Feb 11, 2026
16 of 19 checks passed
@github-actions github-actions bot removed the w-ci label Feb 11, 2026
@jamesavechives
Copy link
Contributor Author

CI is failing and should be fixed

Thanks! Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants