-
Notifications
You must be signed in to change notification settings - Fork 879
Add ERC: Wallet Call Gas Limit Override Capability #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
File
|
|
The commit cdbb6bf (as a parent of f68d50e) contains errors. |
| @@ -0,0 +1,139 @@ | |||
| --- | |||
| title: Gas Limit Override Capability | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more descriptive name?
| title: Gas Limit Override Capability | |
| title: Gas Limit Override for ERC-5792 batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was kind of just following the pattern set by other 5792 capabilities, but agree there's room to be more descriptive. Other examples:
- ERC-7682 - Auxiliary Funds Capability
- ERC-7677 - Paymaster Web Service Capability
- ERC-7902 - Wallet Capabilities for Account Abstraction
- ERC-7795 - Wallet Call Token Capabilities
Given that EIP-5792 is called "Wallet Call API", maybe Wallet Call Gas Limit Override Capability would be more descriptive? WDYT?
This ERC introduces a
gasLimitOverridecapability for EIP-5792, allowing apps to specify per-call gas limits when usingwallet_sendCalls. Apps often have more context about expected gas usage than wallets, particularly for calls with nondeterministic behavior. Wallets are responsible for estimating any batching overhead and for calls where apps don't provide a limit.Discussion link: https://ethereum-magicians.org/t/new-erc-gas-limit-override-capability/25159