Skip to content

order signing fixes #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkrizan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

order signing fixes #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 52 additions & 10 deletions dotnet/Service.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@
using System.Linq;
using System.Numerics;
using System.Threading.Tasks;
using Nethereum.ABI.FunctionEncoding;
using Nethereum.ABI.Encoders;
using Nethereum.ABI.Model;
using Nethereum.Contracts;
using Nethereum.Hex.HexConvertors.Extensions;
using Nethereum.Hex.HexTypes;
using Nethereum.KeyStore.Crypto;
using Nethereum.RPC.Eth.DTOs;
using Nethereum.Signer;
using Nethereum.Web3;
Expand Down Expand Up @@ -152,13 +153,18 @@ internal Order CreateOrder(OrderType orderType, BigInteger expires, BigInteger p
new Parameter("uint256",1)
};

var pe = new ParametersEncoder();
var data = pe.EncodeParameters(prms, plainData);
var data = SolidityPack(plainData, prms);
var keystoreCrypto = new KeyStoreCrypto();

var hashed = keystoreCrypto.CalculateSha256Hash(data);

var ms = new MessageSigner();
var signature = ms.HashAndSign(data, Config.PrivateKey);

var ethEcdsa = MessageSigner.ExtractEcdsaSignature(signature);
var signer = new EthereumMessageSigner();
var newHash = signer.HashPrefixedMessage(hashed);


var signatureRaw = signer.SignAndCalculateV(newHash, Config.PrivateKey);


var order = new Order
{
Expand All @@ -170,15 +176,51 @@ internal Order CreateOrder(OrderType orderType, BigInteger expires, BigInteger p
Expires = expires,
Nonce = orderNonce,
User = Config.User,
V = ethEcdsa.V,
R = ethEcdsa.R.ToHex(true),
S = ethEcdsa.S.ToHex(true)
V = signatureRaw.V,
R = signatureRaw.R.ToHex(true),
S = signatureRaw.S.ToHex(true)
};

return order;
}
private byte[] SolidityPack(object[] paramsArray, Parameter[] paramsTypes)
{
var intTypeEncoder = new IntTypeEncoder();
var cursor = new List<byte>();
for (var i = 0; i < paramsArray.Length; i++)
{

if (paramsTypes[i].Type == "address")
{
cursor.AddRange(EncodePacked(paramsArray[i]));
}
else if (paramsTypes[i].Type == "uint256")
{
cursor.AddRange(intTypeEncoder.Encode(paramsArray[i]));
}

}

return cursor.ToArray();
}

private byte[] EncodePacked(object value)
{
var strValue = value as string;

if (strValue == null) throw new Exception("Invalid type for address expected as string");

if (strValue != null
&& !strValue.StartsWith("0x", StringComparison.Ordinal))
value = "0x" + value;

if (strValue.Length == 42) return strValue.HexToByteArray();

throw new Exception("Invalid address (should be 20 bytes length): " + strValue);
}


internal void Close()
internal void Close()
{
Log("Closing ...");
if (this._socket != null && this._socket.State == WebSocketState.Open)
Expand Down