Conversation
|
@oed is attempting to deploy a commit to the Eternal Safe Team on Vercel. A member of the Team first needs to authorize it. |
oed
commented
Mar 13, 2025
Contributor
|
I've taken this for a spin and it seems to work nicely with the TX builder. More complex safe apps however tend to fail (tested a few from https://github.com/safe-global/safe-apps-list/blob/main/config/appsList.js). Any clues as to why this is? They mostly just don't detect that they're being run through the safe UI, or fail to load all together (due to x-frame-options / sameorigin policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
Adds support for safe apps. By default no apps are listed, which means that all apps need to be added manually. This is because right now none of the apps are available over IPFS.
Resolves #6
How this PR fixes it
Adds back upstream safe apps. Users can now add the transaction builder as a custom app.
How to test it
Screenshots
Checklist