Add withRLSAction helper for clean ServerActionResult early returns #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces withRLSAction, a variant of withRLS that allows transaction
callbacks to return ServerActionResult directly. This enables clean
`return error(...)` early returns inside transactions while maintaining
RLS context and transactional atomicity.
Key changes:
- Add withRLSAction helper with automatic rollback on error results
- Refactor 9 functions across 4 files to use the new pattern:
- competition-members.ts: removeCompetitionMember, updateMemberRole,
getEligibleMembers, addCompetitionMemberById
- props.ts: createProp, resolveProp
- competitions.ts: updateCompetition
- forecasts.ts: createForecast, updateForecast
- Consolidate multi-step operations into single atomic transactions
- Eliminate awkward throw/catch string-prefix error handling pattern
Closes #105
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
withRLSAction, a variant ofwithRLSthat allows transaction callbacks to returnServerActionResultdirectlyreturn error(...)early returns inside transactions while maintaining RLS context and transactional atomicityTest plan
withRLSActionhelper has unit test coverageCloses #105
🤖 Generated with Claude Code