Add possibility to enable stream for external use#3
Open
ovallcorba wants to merge 2 commits intoesrf-bliss:masterfrom
Open
Add possibility to enable stream for external use#3ovallcorba wants to merge 2 commits intoesrf-bliss:masterfrom
ovallcorba wants to merge 2 commits intoesrf-bliss:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
At ALBA we are studying to use the detector in saving_manage_mode to Hardware so the Filewriter interface of the detector is enabled and the files are generated by it. However, the scientists and the scientific data management group asked also to have the possibility to get the data via the Stream interface so they can perform a faster processing if necessary.
The plugin is disabling the Stream interface of the detector when enabling the hardware saving mode. To allow both interfaces I added the attribute
stream_external_activethat, when true, it is enabling the Stream interface without setting up any pullers/decompression tasks (since the zmq stream will be for "external" use). The idea is that this can only be set to true in saving_managed set to hardware. The logic is implemented in theStream::setActivemethod so:saving_managed_modeis software, thestream_external_activeis forced to false (in case it was true) and everything works as it is now in stream mode.saving_managed_modeis hardware, if thestream_external_activeis true, the stream interface is enabled and the method exited before setting up the puller/decompression. The plugin works as usual in filewriter mode but we will have also the stream interface enabled for external use.stream_external_activeis enabled, the header detail will be configured (as it is done in this method for the software saving mode).By default the
stream_external_activeattribute is set to false at start, so no changes from the current behaviour. It has been added as an attribute (and not property) to allow start/stop stream without restarting the server.I was considering to add the possiblity to change the header_detail for this external stream with another attribute (e.g.
stream_external_header) but I was wandering why not doing it in general for the software saving mode as well. Everything seems ready for lima to deal with this (the functions to change the level, the_get_global_headerthat configures the zmq stream considering theheader_detaillevel, etc...) but I did not find any direct way to change it via the tango device.I am just learning about lima and I tried to be consistent with the rest of the plugin code but any comment/advice from your side will be appreaciated.
Thanks!
Oriol.